Merge pull request #25 from NordSecurity/safer_enum_converter

Enum converter: write enums based on variant, instead of casting to uint

Author: Lipt0nas

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Scaffolding: Decorate public functions with `__declspec(dllexport)` under Windows and `__attribute__((visibility("default")))` on other platforms
 - Core: Make complex function arguments be passed by `const&` for non-callback functions
+- Core: Write enums based on variant instead of casting to uint during conversion
 
 #### v0.4.0+v0.25.0
 

bindgen/src/bindings/cpp/templates/enum_tmpl.cpp

@@ -32,7 +32,15 @@ RustBuffer {{ ffi_converter_name }}::lower(const {{ type_name }} &val) {
 }
 
 void {{ ffi_converter_name }}::write(RustStream &stream, const {{ type_name }} &val) {
-    stream << static_cast<int32_t>(val);
+    switch (val) {
+        {% for variant in e.variants() %}
+    case {{ type_name }}::{{ variant|variant_name }}:
+        stream << static_cast<int32_t>({{ loop.index }});
+        break;
+        {% endfor %}
+    default:
+        throw std::runtime_error("No matching {{ type_name }} variant");
+    }
 }
 
 int32_t {{ ffi_converter_name }}::allocation_size(const {{ type_name|class_name }} &) {
@@ -122,4 +130,4 @@ int32_t {{ ffi_converter_name }}::allocation_size(const {{ type_name|class_name
 
     return size;
 }
-{%- endif %}
+{%- endif %}