-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nodes/marks passing to resolveFn, update demo and README #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Edo-San could you please review the code? |
Signed-off-by: Edvinas Jurele <[email protected]>
edvinasjurele
force-pushed
the
feat/expose-content-to-renderfn
branch
from
March 8, 2024 13:03
3c4073f
to
cb55c3a
Compare
Edo-San
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @edvinasjurele
Thank you again for your effort! 🙏
yohlime
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, thank you @edvinasjurele and @Edo-San
yohlime
approved these changes
Mar 9, 2024
developer-ns
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129
Exposing
node
andmark
objects to be accessible via nodes and marks resolver functions. This adds possibility to access the whole rich text node, includingtype
,attrs
, and most importantly,content
data, allowing more advanced configuration possibilities.Especially useful when the component supports data passing via props only, and do not support
<slot />
to pass the data as children, f.e. https://docs.astro.build/en/reference/api-reference/#code-The PR makes it possible to configure such components with
RichTextRenderer
.Changes
content
inside schema resolversCodeBlock
component in favour of native Astro Code componentHeading
component which is has no slots, thus data is via props only as an example