Fix possible ip spoofing while searching for upnp gateway #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszklak
force-pushed
the
ip-spoofing-in-response
branch
5 times, most recently
from
6ea6a08 to
4666493
Compare
LukasPukenis
reviewed
Dec 5, 2024
This is mostly getting rid of the pre-1.0 hyper version, and using only one http client library.
tomaszklak
force-pushed
the
ip-spoofing-in-response
branch
2 times, most recently
from
a98baa9 to
13b08bf
Compare
Gateway searching tests extracted out of async only code into a common test module.
tomaszklak
force-pushed
the
ip-spoofing-in-response
branch
from
13b08bf to
2f851c8
Compare
stalowyjez
previously approved these changes
Dec 10, 2024
tomaszklak
force-pushed
the
ip-spoofing-in-response
branch
from
2f851c8 to
1bc1638
Compare
stalowyjez
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, direct dependencies are shrank and updated, and sync and async implementations are refactored to have less duplication between them.
Commit by commit review might be easier.