Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of 'settings' command to include arguments of 'set' #436

Open
cargocultprogramming opened this issue Jun 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cargocultprogramming
Copy link

I keep stumbling over my own help threads when hunting for the correct CLI arguments. There is no straight-forward way to infer arguments to set from the output of settings:

> nordvpn settings
Technology: NORDLYNX
Firewall: enabled
Firewall Mark: 0xe1f1
Routing: enabled
Analytics: enabled
Kill Switch: disabled
Threat Protection Lite: enabled
Notify: disabled
Auto-connect: enabled
IPv6: disabled
Meshnet: disabled
DNS: disabled
LAN Discovery: enabled

Now if I want to set "LAN Discovery" on, what is the command for that?

nordvpn set LANDiscovery
nordvpn set "LAN Discovery"
nordvpn set landiscovery
nordvpn set lan_discovery
nordvpn set lan-discovery  <-- ah finally!

The man page doesn't tell me that and in addition the recipe "dash instead of space" is not consistent because the cli options are "killswitch" and "threatprotectionlite" and not "kill-switch" and "threat-protection-lite" for the settings "Kill Switch" and "Threat Protection Lite", though these at least are mentioned in the man-page. Conversely "Auto-connect" drops the dash - the cli argument is autoconnect.

The only way to find all arguments is nordvpn set --help and from there the details under nordvpn set lan-discovery --help.

Please amend the output of settings to include the actual arguments to be used to change the settings. It's simple and makes life a lot easier for those of us who don't use the cli every day.

@mariusSincovici
Copy link
Contributor

Hi,
thank you for your feedback and suggestions.
It is planned to review the commands in the future, so we'll forward this information.

@mariusSincovici mariusSincovici added the enhancement New feature or request label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants