Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step-wise introduction of T-dep. and O2-dep of remineralization? #400

Closed
jmaerz opened this issue Sep 12, 2024 · 4 comments · Fixed by #424
Closed

Step-wise introduction of T-dep. and O2-dep of remineralization? #400

jmaerz opened this issue Sep 12, 2024 · 4 comments · Fixed by #424

Comments

@jmaerz
Copy link
Collaborator

jmaerz commented Sep 12, 2024

Hi @JorgSchwinger and @TomasTorsvik , as we discussed to move on and enable T-dep. and O2-dependent remineralization (#340): shall we perform this for the default iHAMOCC version in a two-step process (i.e. providing switches, which may then later be removed)?

@JorgSchwinger
Copy link
Contributor

Maybe a two step process, but with the clear aim to remove the switch once a longer model run has shown that it behaves as expected?

@TomasTorsvik
Copy link
Contributor

Maybe a two step process, but with the clear aim to remove the switch once a longer model run has shown that it behaves as expected?

Sounds reasonable to me.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Sep 13, 2024

Ok, then we go that route. For now, I suggest that anyone who is providing the switch shall briefly announce it here, before modifying the code so that work isn't done twice. (I likely touch it soon, but don't wanna promise right now.)

@jmaerz
Copy link
Collaborator Author

jmaerz commented Oct 25, 2024

I introduce the switch in #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants