fix(js-x-ray): use new externalIdentifierLookup function for ast utilities (#371)

Author: fraxken

workspaces/js-x-ray/src/probes/isRequire/RequireCallExpressionWalker.ts

@@ -96,8 +96,11 @@ export class RequireCallExpressionWalker {
   ): void {
     const nodeArguments = getCallExpressionArguments(
       node,
-      { tracer: this.tracer }
+      {
+        externalIdentifierLookup: (name) => this.tracer.literalIdentifiers.get(name) ?? null
+      }
     );
+
     if (nodeArguments !== null && nodeArguments.length > 0) {
       this.dependencies.add(
         Buffer.from(nodeArguments.at(0)!, "base64").toString()

workspaces/js-x-ray/src/probes/isRequire/isRequire.ts

@@ -113,7 +113,11 @@ function main(
 
     // require(["ht", "tp"])
     case "ArrayExpression": {
-      const value = [...arrayExpressionToString(arg, { tracer })]
+      const value = [
+        ...arrayExpressionToString(arg, {
+          externalIdentifierLookup: (name) => tracer.literalIdentifiers.get(name) ?? null
+        })
+      ]
         .join("")
         .trim();
 
@@ -139,7 +143,8 @@ function main(
 
       try {
         const iter = concatBinaryExpression(arg, {
-          tracer, stopOnUnsupportedNode: true
+          externalIdentifierLookup: (name) => tracer.literalIdentifiers.get(name) ?? null,
+          stopOnUnsupportedNode: true
         });
 
         sourceFile.addDependency([...iter].join(""), node.loc);

workspaces/js-x-ray/src/probes/isSyncIO.ts

@@ -42,7 +42,12 @@ function validateNode(
   node: ESTree.Node,
   { tracer }: SourceFile
 ): [boolean, any?] {
-  const id = getCallExpressionIdentifier(node, { tracer });
+  const id = getCallExpressionIdentifier(
+    node,
+    {
+      externalIdentifierLookup: (name) => tracer.literalIdentifiers.get(name) ?? null
+    }
+  );
   if (
     id === null ||
     !kTracedNodeCoreModules.some((moduleName) => tracer.importedModules.has(moduleName))