Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtkit: reduce logging #247054

Merged
merged 1 commit into from
Aug 20, 2023
Merged

rtkit: reduce logging #247054

merged 1 commit into from
Aug 20, 2023

Conversation

KenMacD
Copy link
Contributor

@KenMacD KenMacD commented Aug 4, 2023

Pull in a patch from a cleaner upstream PR to reduce logging.

Slightly update the URLs used to download the existing patches to make it easier to find the relevant PRs.

Re: #180102, heftig/rtkit#22

heftig/rtkit#33

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Pull in a patch from a cleaner upstream PR to reduce logging.

Slightly update the URLs used to download the existing patches
to make it easier to find the relevant PRs.

Re: NixOS#180102, heftig/rtkit#22
@Artturin
Copy link
Member

tested with overlay

rtkit = super.rtkit.overrideAttrs (previousAttrs: {
  patches = (previousAttrs.patches or [ ]) ++ [
    (super.fetchpatch {
      name = "rtkit-daemon-dont-log-debug-messages-by-default.patch";
      url = "https://github.com/heftig/rtkit/pull/33/commits/ad649ee491ed1a41537774ad11564a208e598a09.patch";
      sha256 = "sha256-p+MdJVMv58rFd1uc1UFKtq83RquDSFZ3M6YfaBU12UU=";
    })
  ];
});

and there's no debug messages

stopping the service and running sudo /nix/store/pkrajd5mb0yra9f8l1bki2d740qsmv0c-rtkit-0.13/libexec/rtkit-daemon --debug
and now there's debug messages

@Artturin Artturin merged commit f03d4e0 into NixOS:master Aug 20, 2023
12 checks passed
@KenMacD KenMacD deleted the rtkit-reduce-logging branch August 23, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants