Build failure: gimpPlugins.bimp

[bddvlpr]

Steps To Reproduce

Steps to reproduce the behavior:

1. build gimpPlugins.bimp on unstable.

Build log

See the Hydra build logs.

Notify maintainers

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[paparodeo]

upstream issue: alessandrofrancesconi/gimp-plugin-bimp#411

a couple of ways to fix the build:

void casts

diff --git a/pkgs/applications/graphics/gimp/plugins/default.nix b/pkgs/applications/graphics/gimp/plugins/default.nix
index bf30838cc12b..aa20f129019e 100644
--- a/pkgs/applications/graphics/gimp/plugins/default.nix
+++ b/pkgs/applications/graphics/gimp/plugins/default.nix
@@ -115,16 +115,14 @@ lib.makeScope pkgs.newScope (
       postPatch = ''
         substituteInPlace Makefile \
           --replace-fail "gcc" "${stdenv.cc.targetPrefix}cc"
+
+        # https://github.com/alessandrofrancesconi/gimp-plugin-bimp/issues/411
+        substituteInPlace src/bimp-manipulations-gui.c \
+          --replace-fail "save = &" "save = (void (*)(void*))"
       '';
 
       nativeBuildInputs = with pkgs; [ which ];
 
-      env.NIX_CFLAGS_COMPILE = toString (
-        lib.optionals stdenv.cc.isClang [
-          "-Wno-error=incompatible-function-pointer-types"
-        ]
-      );
-
       installFlags = [
         "SYSTEM_INSTALL_DIR=${placeholder "out"}/${gimp.targetPluginDir}/bimp"
       ];

or

disable error

diff --git a/pkgs/applications/graphics/gimp/plugins/default.nix b/pkgs/applications/graphics/gimp/plugins/default.nix
index bf30838cc12b..f1cbac4d0242 100644
--- a/pkgs/applications/graphics/gimp/plugins/default.nix
+++ b/pkgs/applications/graphics/gimp/plugins/default.nix
@@ -119,11 +119,7 @@ lib.makeScope pkgs.newScope (
 
       nativeBuildInputs = with pkgs; [ which ];
 
-      env.NIX_CFLAGS_COMPILE = toString (
-        lib.optionals stdenv.cc.isClang [
-          "-Wno-error=incompatible-function-pointer-types"
-        ]
-      );
+      env.NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-pointer-types";
 
       installFlags = [
         "SYSTEM_INSTALL_DIR=${placeholder "out"}/${gimp.targetPluginDir}/bimp"

feel free to open a PR