Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefoxpwa: missing support for custom runtimes #344442

Open
brckd opened this issue Sep 25, 2024 · 1 comment
Open

firefoxpwa: missing support for custom runtimes #344442

brckd opened this issue Sep 25, 2024 · 1 comment
Labels
0.kind: bug Something is broken

Comments

@brckd
Copy link

brckd commented Sep 25, 2024

Describe the bug

A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Install pkgs.firefoxpwa.
  2. Symlink ~/.local/share/firefoxpwa/runtime to librewolf
  3. Install a PWA like firefoxpwa site install https://regex101.com/static/assets/manifest.webmanifest
  4. Run the PWA
  5. The PWA is run using Firefox, not LibreWolf.

Expected behavior

I would like to use librewolf as runtime instead. There are two ways to accomplish htis.

  1. Make it possible to override the binary in the following line.
    cp -Lr ${firefox-unwrapped}/lib/firefox $out/share/firefoxpwa/runtime
  2. Remove the immutable runtime alltogether and instead source from ~/.local/share/firefoxpwa/runtime

Additional context

Discussion about packaging and immutable runtime: filips123/PWAsForFirefox#204

librewolf-unwrapped/lib/librewolf exposes librewolf-bin instead of firefox-bin. Depending on how PWAsForFirefox sources the immutable runtime binary, it may need to be symlinked as firefox-bin.

Notify maintainers

@adamcstephens @camillemndn @pasqui23

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.52, NixOS, 24.11 (Vicuna), 24.11.20240921.9357f4f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.7`
 - nixpkgs: `/nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source`

Add a 👍 reaction to issues you find important.

@brckd brckd added the 0.kind: bug Something is broken label Sep 25, 2024
@adamcstephens
Copy link
Contributor

I have no plan to extend support beyond the standard firefox package. At most I'll review a PR to make sure it doesn't break firefox, but otherwise someone else will need to do the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants