nixfmt-classic: Stop using the hackage package #359388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency on the hackage package so we can finally fix NixOS/nixfmt#161 and also moves the entire package to pkgs/by-name.
dasJ
force-pushed
the
feat/move-nixfmt-classic
branch
from
83b7372 to
d94e1a6
Compare
|
I don't think this is neccessary. Hackage is append only. nixfmt can never be removed there. I see no reason not to fetch the old version from there. Or is the maintainer team planning to release updates for the classic version? |
|
Thanks for that info, didn't know that. No, we (the formatting team) are not planning to release updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on the hackage package so we can finally fix NixOS/nixfmt#161 and also moves the entire package to pkgs/by-name.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)cc @NixOS/nix-formatting
Add a 👍 reaction to pull requests you find important.