Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Hackage package #161

Open
infinisil opened this issue Mar 13, 2024 · 4 comments
Open

Deprecate Hackage package #161

infinisil opened this issue Mar 13, 2024 · 4 comments

Comments

@infinisil
Copy link
Member

Nixfmt is currently on Hackage, but I don't think that's necessary:

  • While pkgs.nixfmt is currently being populated by Hackage, there's no reason this would be necessary to build a Haskell package in Nix. Indeed the new pkgs.nixfmt-rfc-style works without Hackage
  • Nixfmt doesn't really have an API surface that would be useful enough on its own. I consider it an end-user application. If some useful and reusable API surface emerges from the codebase, we can still consider packaging that on Hackage.

So I'd propose deprecating the Hackage package and not updating it anymore. This way nixfmt on Hackage will always be the legacy Serokell version.

This will remove a bunch of maintenance burden from the formatter team.

Ping @Sereja313 @Lucus16 @yorickvP
@Sereja313
Copy link
Member

I agree

@infinisil infinisil changed the title Remove from Hackage Deprecate Hackage package Mar 14, 2024
infinisil added a commit that referenced this issue Mar 14, 2024
@infinisil
Always just executables and don't build haddock
f34cd7a 
- Doesn't inflate closure size to over 2GB, see #143
- The API docs aren't important and we're intending on deprecating the
  hackage package, see #161
infinisil added a commit that referenced this issue Mar 14, 2024
@infinisil
Always just executables and don't build haddock
4de3b1b 
- Doesn't inflate closure size to over 2GB, see #143
- The API docs aren't important and we're intending on deprecating the
  hackage package, see #161
infinisil added a commit that referenced this issue Mar 14, 2024
@infinisil
Always just executables and don't build haddock
dfe157e 
- Doesn't inflate closure size to over 2GB, see #143
- The API docs aren't important and we're intending on deprecating the
  hackage package, see #161
@infinisil infinisil mentioned this issue Mar 15, 2024
Merged
@dasJ
Copy link
Member

dasJ commented Apr 2, 2024

Somebody from the maintainers team probably has to do this

@infinisil
Copy link
Member Author

Yeah I could do that, should I do it already or should we wait until we have a first initial release? It might also be a good idea to update the Hackage page with a bit of information about the deprecation.

@dasJ
Copy link
Member

dasJ commented Apr 3, 2024

We should also move the nixfmt-classic package in nixpkgs first to make sure it doesn't point to a non-existing hackage package.

@infinisil infinisil moved this to Todo in Nix formatting May 28, 2024
@dasJ dasJ mentioned this issue Nov 26, 2024
Closed
13 tasks
dasJ added a commit to helsinki-systems/nixpkgs that referenced this issue Nov 26, 2024
@dasJ
nixfmt-classic: Stop using the hackage package
d94e1a6 
Removes dependency on the hackage package so we can finally fix
NixOS/nixfmt#161 and also moves the entire
package to pkgs/by-name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Nix formatting
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nixfmt-classic: Stop using the hackage package helsinki-systems/nixpkgs
3 participants
@dasJ @infinisil @Sereja313