Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-library-profiling option #582

Open
locallycompact opened this issue Oct 31, 2022 · 2 comments
Open

Add --disable-library-profiling option #582

locallycompact opened this issue Oct 31, 2022 · 2 comments

Comments

@locallycompact
Copy link

enableLibraryProfiling = true seems to be the default when I use cabal2nix, can we have an explicit option to set it to false?

@locallycompact
Copy link
Author

I made an alternate fix for this by just explicitly writing the attr instead of boolattr for these options, but further to that opinion I think boolattr is prone to breakage because we can never assume how nixpkgs will interpret a missing key into configure options, so in the interest of discoverability I don't think boolattr is a good idea.

#583

@locallycompact
Copy link
Author

Ok I just changed it to make boolattr always write out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants