Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of legacy dependencies #404

Open
dvzrv opened this issue Jun 7, 2023 · 2 comments
Open

Use of legacy dependencies #404

dvzrv opened this issue Jun 7, 2023 · 2 comments

Comments

@dvzrv
Copy link

dvzrv commented Jun 7, 2023

Hi! When trying to upgrade to 0.4.38 I noticed that you have added a new dependency on click-aliases.

The project has not done a release since 2019 and although upstream seems not completely dead, it not testing against anything newer than Python 3.7, nor against click > 7 is very concerning.

From a developer's point of view I fully understand that you need to rely on 3rd party dependencies, however, please make sure that these are still alive and (ideally) tested against recent Python releases and the ecosystem (e.g. click) they integrate with.

As pynitrokey does neither have blanket unit tests, which ensure that runtime dependencies are met, nor declares dependency changes in the changelog, it is very easy to miss changes as a downstream packager.

@dvzrv
Copy link
Author

dvzrv commented Jun 7, 2023

Case in point: click-contrib/click-aliases#5 (comment) 🥲

@robin-nitrokey
Copy link
Member

Since this issue has been opened, there have been four new releases for click-alias. The unit tests work for me with release v1.0.5. Is the dependency still a problem for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants