Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_status for Nitrokey Storage #166

Open
robinkrahl opened this issue Jan 5, 2020 · 0 comments
Open

Fix get_status for Nitrokey Storage #166

robinkrahl opened this issue Jan 5, 2020 · 0 comments

Comments

@robinkrahl
Copy link
Contributor

Until the GET_STATUS command is fixed in the Nitrokey Storage firmware, see Nitrokey/nitrokey-storage-firmware#96, libnitrokey’s get_status function should additionally execute the GET_DEVICE_STATUS command for the Nitrokey Storage to get the firmware version (and possibly the serial number – it isn’t correct either, but it’s better to be consistent).
robinkrahl added a commit to robinkrahl/libnitrokey that referenced this issue Jan 5, 2020
@robinkrahl
Also execute GET_DEVICE_STATUS in get_status for Storage
dd0cdcd 
As described in this issue [0], the GET_STATUS command does not work for
the Nitrokey Storage.  Therefore, NitrokeyManager::get_status does not
work either.  To fix this, we additionally execute the GET_DEVICE_STATUS
command if a Nitrokey Storage is detected to determine the serial number
and the firmware version.  This also fixes the failing test
test_get_status that we introduced in the last patch.

Fixes Nitrokey#166.

[0] Nitrokey/nitrokey-storage-firmware#96
@robinkrahl robinkrahl mentioned this issue Jan 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robinkrahl