Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to federated plugin #13

Open
sebastianhaberey opened this issue Aug 29, 2021 · 3 comments
Open

Migrate to federated plugin #13

sebastianhaberey opened this issue Aug 29, 2021 · 3 comments

Comments

@sebastianhaberey
Copy link

I was thinking it would be good to migrate the plugin to the federated plugin structure to facilitate contribution. As I understand, this would enable developers to contribute platform implementations in their own repositories, without having to go through PRs. Also, it's how the packages maintained by the Flutter team (such as url_launcher and shared_preferences) are structured now.

The necessary steps are detailed here:

  1. Create platform interface package
  2. Publish to pub.dev
  3. Refactor base package to use platform interface package

I think I'm done with step 1, you can preview it here. I'm not sure how to proceed though, since I can't publish under your name (of course). Let me know if you're interested in doing this. If you don't have the time / resources to do it, I understand, too!

@Nimrodda
Copy link
Owner

Interesting. I need to learn a bit more about federated plugins. I thought it's just another way to organize the codebase 🤔

@sebastianhaberey
Copy link
Author

I am also just learning about it. The concept is fairly new and the Flutter team hasn't finalized it yet, but it seems it's the way they want to go in the future.

Since federated plugins involve a lot more publishing, I think what I want to do is publish a "federated" version of the plugin using my account to save us both a lot of back and forth. Also, I have a few major changes in mind that will be easier to carry out that way.

@Nimrodda
Copy link
Owner

Nimrodda commented Sep 3, 2021

From what I read it doesn't sound like a lot of publishing. After the plugin is converted to a federated plugin, I need to endorse your plugin by adding it to pubspec and then publish a new version. Doesn't sound to me like a lot of a hassle. I think it would be better to have the community working on one repo together instead of splitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants