Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated cmake-modules in each submodule #143

Open
makxenov opened this issue Feb 7, 2024 · 1 comment
Open

Duplicated cmake-modules in each submodule #143

makxenov opened this issue Feb 7, 2024 · 1 comment

Comments

@makxenov
Copy link
Contributor

makxenov commented Feb 7, 2024

Most of crypto3 libraries have cmake_modules as a submodule. I see it useless because even if their versions are different, the local copy will not override the first loaded module. For example, in zkllvm environment, every cm_* function will be loaded from zkllvm/cmake/modules(root repository). I think that we should remove this duplication and have only one source of modules.

@x-mass
Copy link
Contributor

x-mass commented Feb 9, 2024

This could potentially allow us to build them as stand-alone modules (group of modules most times, because of dependencies).
Say, you have installed entire crypto3, then clone only hash repo, make changes and could build it as is, not as part of crypto3.

Good question here is if we really need to provide users an ability to handle stand-alone modules. crypto3 is not that big to be fetched as a single package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants