Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the functions must start returning a status. #132

Open
martun opened this issue Jan 12, 2024 · 0 comments
Open

All the functions must start returning a status. #132

martun opened this issue Jan 12, 2024 · 0 comments

Comments

@martun
Copy link
Contributor

martun commented Jan 12, 2024

Every time marshalling happens, we receive a status: "nil::marshalling::status_type status".
We must stop ignoring these statuses, because someone may intentionally give us a wrong structure on input.
We can not use throw/catch in our code, since we want to keep the potential ability to compile crypto3 code into an EVM bytecode.

So far the best solution is to propagate these statuses up through all the functions, which will require lots of code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant