Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review parameters for edwards_183 g2 curve #161

Open
vo-nil opened this issue May 11, 2024 · 0 comments
Open

Review parameters for edwards_183 g2 curve #161

vo-nil opened this issue May 11, 2024 · 0 comments

Comments

@vo-nil
Copy link
Contributor

vo-nil commented May 11, 2024

With current parameters for g2 curve the generator ::one() is not well-formed.
https://github.com/NilFoundation/crypto3-algebra/blob/master/include/nil/crypto3/algebra/curves/detail/edwards/basic_policy.hpp#L101

Looks like parameters were sourced from here: https://math.mit.edu/~drew/EdwardsE6.html
But there is no evidence of parameters for twisted E' curve.
The generator value is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant