Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kira's Clocks #65

Open
NiklasEi opened this issue Aug 10, 2022 · 4 comments
Open

Support Kira's Clocks #65

NiklasEi opened this issue Aug 10, 2022 · 4 comments

Comments

@NiklasEi
Copy link
Owner

See https://tesselode.github.io/kira/clocks.html

@james-j-obrien
Copy link

I need to leverage clocks for my use case. I had started manually depending on kira directly in order to gain access to them but it would be great to have it upstreamed rather than duplicating that effort.

Would you be open to discussing how these would ideally be integrated to bevy_kira_audio so that I could start implementing a PR with clock support? Otherwise I'll just do my own implementation locally

@james-j-obrien
Copy link

james-j-obrien commented Aug 22, 2022

I have a fork that has basic, quick and dirty support here: https://github.com/james-j-obrien/bevy_kira_audio
Missing docs and dynamic clock support but appears to work as expected.

@RustyJoeM
Copy link

Has there been any progress in the backround on the Clocks support?

I am trying to implement a simple "metronome" in Bevy and am wondering whether it's possible with this plugin (or kira directly?) to do some sort of "looping"...

So that the repetition of Clock-ed sounds is done by kira/bevy_kira_audio/bevy, and external synchronization is not needed every "tact" to re-execute playback of beats...

@NiklasEi
Copy link
Owner Author

NiklasEi commented Jul 20, 2023

I have not worked on clocks, but I am certainly open to contributions concerning them. What @james-j-obrien did looks good as a starting point.
It would be nice to add an example to the repository using the new API, so I can see a use case and what the user code would look like.

Would you be open to discussing how these would ideally be integrated to bevy_kira_audio so that I could start implementing a PR with clock support?

I am not sure about the API because I have never used clocks before and don't really know how one would want to use them. If you are still interested in getting this upstreamed, I would be interested in how you use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants