-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# --> C++ #784
Draft
nlogozzo
wants to merge
174
commits into
main
Choose a base branch
from
cpp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
C# --> C++ #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add group.h and group.cpp * Fix styling + add to CMakeLists.txt * Shared - Add Color to group.h * Shared - Formatting fixes
…controller AccountSettingsController
* GNOME: Throw runtime_error with reason if gresource failed to load * GNOME: Print to stderr if failed to load blueprint files * GNOME: mainwindow - Panic and exit early if m_window is null This can happen for example when the complied ui files are missing, causing m_build and thereby m_window to be null * libdenaro: Default to USD when locale isn't set * GNOME: mainwindowcontroller - Show locale not set in debug info instead of crashing * style changes * Gnome: remove m_window == null check on startup * Gnome: throw invalid argument exception if path for blueprint doesn't exist * Gnome: about - remove unused variable * Update libnick * Use logging from libnick * Throw runtime_error when blueprints are missing * Update libnick * Shared - Taskbar Logging * mainwindowcontroller: add more logs * mainwindowcontroller: code review fixes * mainwindowcontroller: accout open and remove info logs * All - Add Logs --------- Co-authored-by: Nick Logozzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #746
Fixes #747
Fixes #765
Fixes #794
TODO
generateGraph
andexportToPDF
Implementations)