Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 Hour Clock Formatting Issues #317

Open
GonzalesGabe opened this issue Dec 8, 2024 · 2 comments
Open

12 Hour Clock Formatting Issues #317

GonzalesGabe opened this issue Dec 8, 2024 · 2 comments

Comments

@GonzalesGabe
Copy link

Describe the bug.

When the 12 hour clock is enabled, the lock screen clock shows a leading zero for single-digit hours, and "12:XXam" is incorrectly shown as "00:XXam"

Reproduction

Make sure 12h clock is enabled
check lockscreen

Target

No response

Logs

No response

Anything else?

the leading zero issue is also present in the status bar clock, like the official firmware. If this is actually a system limitation, I understand it might not be fixable within Momentum Firmware

@Willy-JL
Copy link
Member

Willy-JL commented Dec 8, 2024

Personally I find 00:xx am to be more obvious when wanting to indicate that it is just past midnight. 12:xx am is ambiguous whether it means midnight or midday imo
Is there some standard saying it should be 12:xx am?

@GonzalesGabe
Copy link
Author

GonzalesGabe commented Dec 8, 2024

Personally I find 00:xx am to be more obvious when wanting to indicate that it is just past midnight. 12:xx am is ambiguous whether it means midnight or midday imo Is there some standard saying it should be 12:xx am?

First of all that's a very fair point, I get what you mean, I do see that 00:xx am may feel more explicit/clear for differentiating between midnight and midday, but in a traditional 12 hour clock format,

12:XX AM is midnight
12:XX PM is noon
This is widely accepted in many regions, especially the US, while 00:XX is more associated with 24 hour clocks. It just kind of feels out of place to me. Would it be possible to offer a toggle/customization option so users can choose their preferred midnight formatting (12:XXam vs 00:XXam) so it would cater to both preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants