Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF App: Unpredictable Crashes on Read #6

Open
zacharyweiss opened this issue Apr 22, 2024 · 5 comments
Open

UHF App: Unpredictable Crashes on Read #6

zacharyweiss opened this issue Apr 22, 2024 · 5 comments
Labels
bugfix Something isn't working needs-more-info Requires more information to triage

Comments

@zacharyweiss
Copy link
Contributor

zacharyweiss commented Apr 22, 2024

I'm running into a number of crashes with the UHF app bundled here. I initially detailed these on the app's main repo, but after a bit more investigation, it appears to be something unique to the modified code here or how it interacts with the FW; flashing OFW dev & the app's current master branch abates the crashes, but replaces them with intermittent freezes as mentioned in another issue in their repo.

Any thoughts / suggestions on how to tackle debugging? I'm not familiar with all the modifications made here, nor why they were made. Is this better asked of xMasterX on their apps repo?

@Willy-JL
Copy link
Member

Willy-JL commented May 4, 2024

tried with same code as upstream on momentum and results did not change for me, same crashes. maybe its related to some PRs we have merged early into firmware. regardless, there most definitely is some problem with reading, and module initialization too. will look into it when i have the time

@Willy-JL
Copy link
Member

Willy-JL commented May 4, 2024

for some more context, currently the only difference we have from upstream in our code is to do with UART init and deinit, adding some safety checks and removing redundant init by app/hal checks

@zacharyweiss
Copy link
Contributor Author

Interesting; yeah, likely FW related then, or spurious correlation on my part from too few samples

leedave added a commit to leedave/Momentum-Apps that referenced this issue May 13, 2024
Willy-JL pushed a commit that referenced this issue May 19, 2024
Willy-JL pushed a commit that referenced this issue May 19, 2024
searching for error with tmp file being open
Willy-JL pushed a commit that referenced this issue May 26, 2024
@Willy-JL Willy-JL added bugfix Something isn't working needs-more-info Requires more information to triage labels May 28, 2024
@Willy-JL
Copy link
Member

just for an update, this would make it seem like similar behavior to issues with other apps that did not play nicely with new TLSF allocator, however it could be deeper than this. the app author said theyre looking into it on discord and noticed some oddities with commands sending too fast. im not knowlegeable enough on that side of things, at most i could try to track down memory management issues brought to light by TLSF, but it freezing on OFW too makes it seem like the issue is deeper. ill try to have a look when i can however

@frux-c
Copy link
Contributor

frux-c commented Jun 4, 2024

@zacharyweiss Here's a commit that you can try that addresses that issue frux-c/uhf_rfid@e8633bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working needs-more-info Requires more information to triage
Projects
Status: Next Up
Development

No branches or pull requests

3 participants