Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#serialized_json for empty collection #466

Open
jji-fieldwire opened this issue Jun 9, 2020 · 1 comment
Open

#serialized_json for empty collection #466

jji-fieldwire opened this issue Jun 9, 2020 · 1 comment

Comments

@jji-fieldwire
Copy link

Hi,

Behavior for serializer passed empty collection is to return nil

I think it would make more sense for the serializer to return []. Ideally would work with empty Array and empty Relation.

##### Current behavior
UserSerializer.new([]).serialized_json
=> nil

##### Desired behavior(?)
UserSerializer.new(User.where.not(id: nil)).serialized_json
=> "[]"
@davidwparker
Copy link

#462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants