You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was first brought to my attention in #140, which identifies a specific subset ([[]]) supposedly produced by one specific tool (gdal-bin ogr2ogr) and resolves that to do the right thing.
While that PR is a good first step, we should fix the underlying issue more completely and generically, such that an empty Polygon array anywhere within the MultiPolygon's "coordinates" member will be handled properly. Examples for test cases:
[[], []] is a MultiPolygon that contains nothing but two empty Polygons in it
[[[[0, 0], [1, 0], [0, 1], [0, 0]]], []] is a MultiPolygon that contains one empty and one non-empty Polygon
[[], [[[0, 0], [1, 0], [0, 1], [0, 0]]]] is equivalent to the previous row but in a different order (which matters for the spaghetti that implements this parsing logic)
[[], [[[0, 0], [1, 0], [0, 1], [0, 0]]], []] is a combination of both of the previous rows
The text was updated successfully, but these errors were encountered:
This was first brought to my attention in #140, which identifies a specific subset (
[[]]
) supposedly produced by one specific tool (gdal-bin ogr2ogr) and resolves that to do the right thing.While that PR is a good first step, we should fix the underlying issue more completely and generically, such that an empty Polygon array anywhere within the MultiPolygon's
"coordinates"
member will be handled properly. Examples for test cases:[[]]
is aMultiPolygon
that contains one emptyPolygon
in it (fixed by Deserialize MultiPolygon Array of Empty Coordinates Array #140)[[], []]
is aMultiPolygon
that contains nothing but two emptyPolygon
s in it[[[[0, 0], [1, 0], [0, 1], [0, 0]]], []]
is aMultiPolygon
that contains one empty and one non-emptyPolygon
[[], [[[0, 0], [1, 0], [0, 1], [0, 0]]]]
is equivalent to the previous row but in a different order (which matters for the spaghetti that implements this parsing logic)[[], [[[0, 0], [1, 0], [0, 1], [0, 0]]], []]
is a combination of both of the previous rowsThe text was updated successfully, but these errors were encountered: