Should rebase interactive (ri from status buffer on a recent commit) include the selected commit?

[star-szr]

I was watching a demo video of Magit and noticed that when running ri with the cursor on a recent commit, Magit includes that commit in the git-rebase-todo.

Put differently, it's the difference between:

• git rebase -i hash (current Neogit behaviour)
• git rebase -i hash~ (Magit behaviour).

The Magit way seems more intuitive to me, what do you think? Maybe we should update this.

[star-szr]

I should also mention, this should likely apply when using the commit select view as well - for example if you hit ri from the top of the status buffer. The way you select the commit is not the important part, but that the result is what is expected.

[CKolkey]

Well spotted - agreed, we should go with the Magit behaviour.

[CKolkey]

Curious if there are other places like this that got overlooked. Maybe with reset and revert and such?

[CKolkey]

Sounds good to me. Wanna do it?

[star-szr]

I’d be happy to try! Thanks.

[CKolkey]

Of course 😄 lemme know if you have any questions

[ten3roberts]

I am also very much for the rebase interactive includes the selected commit.

While following the behavior of git for commands named the same way is preferably, you need to keep in mind that git is not always the most intuitive, as is well known for many jokes. As such, small things like these which "do what you expect" are very appreciated

❤️

[star-szr]

In case anyone else is following along, I'm posting here to say that I opened #883.

[star-szr]

Closing since this is in now! Thanks.