Skip to content

Commit 3b8a7d4

Browse files
authored
Don't use inv and inv! in ring conformance tests (#2096)
We can't expect general rings to support inv, not even for the ring's one element. These tests may be reactivated in a future version, e.g. if we add an `implements` trait.
1 parent 8b26da5 commit 3b8a7d4

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ext/TestExt/Rings-conformance-tests.jl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,11 @@ function test_Ring_interface(R::AbstractAlgebra.Ring; reps = 50)
230230
test_NCRing_interface(R; reps = reps)
231231

232232
@testset "Basic functionality for commutative rings only" begin
233-
@test isone(AbstractAlgebra.inv(one(R)))
234-
test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, one(R))
235-
test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, -one(R))
233+
# FIXME: we can't expect general rings to support inv, not even for the one
234+
# element, so don't test this
235+
#@test isone(AbstractAlgebra.inv(one(R)))
236+
#test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, one(R))
237+
#test_mutating_op_like_neg(AbstractAlgebra.inv, inv!, -one(R))
236238
for i in 1:reps
237239
a = generate_element(R)::T
238240
b = generate_element(R)::T

0 commit comments

Comments
 (0)