Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll_elem = window #106

Open
de-robat opened this issue Apr 20, 2017 · 2 comments
Open

scroll_elem = window #106

de-robat opened this issue Apr 20, 2017 · 2 comments

Comments

@de-robat
Copy link

Upfront: Thx for this tool, it's really helpfull and saved me a lot of time!

I came across a strange behaviour today though. I tried setting the scroll_element to window for my use case today. Unfortunatley this does not work as expected. "this.scroll_elem.scrollTop" is going to be undefined in this scenario. The proper scrollPosition for the window is derived via

window.pageYOffset;

I'm wondering, whether im doing something wrong here? I'd be happy to create a Pull Request otherwise

@NeXTs
Copy link
Owner

NeXTs commented Apr 20, 2017

Check this PR
#73

@de-robat
Copy link
Author

Yep, this is a solution as well, Thx for ponting me to it. This Request is open since 9Months by now though. Any specific reasons why you dont wan't to merge it? (Besides it obviously has merge Conflicts by now :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants