From e4b6bd74ba34604e6b1120636875f32e943db0a8 Mon Sep 17 00:00:00 2001
From: Rohit Sangwan <rohitsangwan647@gmail.com>
Date: Thu, 3 Oct 2024 11:48:19 +0530
Subject: [PATCH] Rename filterMfdList to manufacturerDataFilters and replace
 mfd with msd

---
 .../universal_ble/UniversalBleFilterUtil.kt   |  6 +++---
 lib/src/universal_ble_filter_util.dart        | 20 +++++++++----------
 windows/src/universal_ble_filter_util.cpp     |  6 +++---
 windows/src/universal_ble_plugin.cpp          |  4 ++--
 4 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/android/src/main/kotlin/com/navideck/universal_ble/UniversalBleFilterUtil.kt b/android/src/main/kotlin/com/navideck/universal_ble/UniversalBleFilterUtil.kt
index 7e992427..472dd809 100644
--- a/android/src/main/kotlin/com/navideck/universal_ble/UniversalBleFilterUtil.kt
+++ b/android/src/main/kotlin/com/navideck/universal_ble/UniversalBleFilterUtil.kt
@@ -77,10 +77,10 @@ class UniversalBleFilterUtil {
         val filters = scanFilter.withManufacturerData.filterNotNull()
         if (filters.isEmpty()) return true
         if (manufacturerDataList.isEmpty()) return false
-        return manufacturerDataList.any { mfd ->
+        return manufacturerDataList.any { msd ->
             filters.any { filter ->
-                mfd.companyIdentifier == filter.companyIdentifier &&
-                        isDataMatching(filter.data, mfd.data, filter.mask)
+                msd.companyIdentifier == filter.companyIdentifier &&
+                        isDataMatching(filter.data, msd.data, filter.mask)
             }
         }
     }
diff --git a/lib/src/universal_ble_filter_util.dart b/lib/src/universal_ble_filter_util.dart
index ddcb98c5..9c19b191 100644
--- a/lib/src/universal_ble_filter_util.dart
+++ b/lib/src/universal_ble_filter_util.dart
@@ -53,31 +53,31 @@ class UniversalBleFilterUtil {
     ScanFilter scanFilter,
     BleDevice device,
   ) {
-    final filterMfdList = scanFilter.withManufacturerData;
-    if (filterMfdList.isEmpty) return true;
+    final manufacturerDataFilters = scanFilter.withManufacturerData;
+    if (manufacturerDataFilters.isEmpty) return true;
 
     List<ManufacturerData> manufacturerDataList = device.manufacturerDataList;
     if (manufacturerDataList.isEmpty) return false;
 
-    return manufacturerDataList.any((deviceMfd) => filterMfdList.any(
-          (filterMfd) => _isManufacturerDataMatch(filterMfd, deviceMfd),
+    return manufacturerDataList.any((deviceMsd) => manufacturerDataFilters.any(
+          (filterMsd) => _isManufacturerDataMatch(filterMsd, deviceMsd),
         ));
   }
 
   bool _isManufacturerDataMatch(
-    ManufacturerDataFilter filterMfd,
-    ManufacturerData deviceMfd,
+    ManufacturerDataFilter filterMsd,
+    ManufacturerData deviceMsd,
   ) {
-    if (filterMfd.companyIdentifier != deviceMfd.companyId) return false;
+    if (filterMsd.companyIdentifier != deviceMsd.companyId) return false;
 
-    Uint8List? filterPayload = filterMfd.payload;
-    Uint8List devicePayload = deviceMfd.payload;
+    Uint8List? filterPayload = filterMsd.payload;
+    Uint8List devicePayload = deviceMsd.payload;
 
     if (filterPayload == null || filterPayload.isEmpty) return true;
     if (devicePayload.isEmpty) return false;
     if (filterPayload.length > devicePayload.length) return false;
 
-    Uint8List? filterMask = filterMfd.mask;
+    Uint8List? filterMask = filterMsd.mask;
 
     if (filterMask != null && filterMask.length == filterPayload.length) {
       for (int i = 0; i < filterPayload.length; i++) {
diff --git a/windows/src/universal_ble_filter_util.cpp b/windows/src/universal_ble_filter_util.cpp
index 27225d9d..1f79550a 100644
--- a/windows/src/universal_ble_filter_util.cpp
+++ b/windows/src/universal_ble_filter_util.cpp
@@ -101,17 +101,17 @@ namespace universal_ble
 
             for (const auto &value : *manufacturerDataList)
             {
-                const auto &deviceMfData = std::any_cast<const UniversalManufacturerData &>(
+                const auto &deviceManufacturerData = std::any_cast<const UniversalManufacturerData &>(
                     std::get<flutter::CustomEncodableValue>(value));
 
-                if (deviceMfData.company_identifier() != filter.company_identifier())
+                if (deviceManufacturerData.company_identifier() != filter.company_identifier())
                     continue;
 
                 // If no data filter, all data matches
                 if (data_filter == nullptr)
                     return true;
 
-                const auto &deviceData = deviceMfData.data();
+                const auto &deviceData = deviceManufacturerData.data();
                 if (deviceData.size() < data_filter->size())
                     continue;
 
diff --git a/windows/src/universal_ble_plugin.cpp b/windows/src/universal_ble_plugin.cpp
index 5044416b..f406339f 100644
--- a/windows/src/universal_ble_plugin.cpp
+++ b/windows/src/universal_ble_plugin.cpp
@@ -753,9 +753,9 @@ namespace universal_ble
       flutter::EncodableList manufacturerDataEncodableList = flutter::EncodableList();
       if (args.Advertisement() != nullptr)
       {
-        for (BluetoothLEManufacturerData mfd : args.Advertisement().ManufacturerData())
+        for (BluetoothLEManufacturerData msd : args.Advertisement().ManufacturerData())
         {
-          UniversalManufacturerData universalManufacturerData = UniversalManufacturerData(static_cast<int64_t>(mfd.CompanyId()), to_bytevc(mfd.Data()));
+          UniversalManufacturerData universalManufacturerData = UniversalManufacturerData(static_cast<int64_t>(msd.CompanyId()), to_bytevc(msd.Data()));
           manufacturerDataEncodableList.push_back(flutter::CustomEncodableValue(universalManufacturerData));
         }
       }