Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-pdf] text tokenize 및 chunking 로직을 적용하고, custom click handler 로직을 적용합니다. #31

Merged
merged 3 commits into from
May 16, 2024
Merged

[react-pdf] text tokenize 및 chunking 로직을 적용하고, custom click handler 로직을 적용합니다. #31

merged 3 commits into from
May 16, 2024

Conversation

2-one-week
Copy link
Member

Related Issue

Describe your changes

  • 한글 PDF 렌더링 시, 느려지는 이슈를 방지하기 위해서, 한글자씩 렌더링 되는 text 들을 하나로 묶어서 렌더링 할 수 있도록 수정했습니다.
  • custom text click handler를 적용하기 위해서는 어절단위로 쪼개서 렌더링 되도록 하여, 불필요한 callback 호출이 없도록 했습니다.

Request

@2-one-week 2-one-week self-assigned this Apr 30, 2024
@2-one-week 2-one-week requested a review from a team as a code owner April 30, 2024 09:55
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 5b556b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@2-one-week 2-one-week enabled auto-merge (rebase) May 9, 2024 08:48
yceffort-naver
yceffort-naver approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@2-one-week 2-one-week merged commit 204eb7f into epic/react_pdf May 16, 2024
3 checks passed
@2-one-week 2-one-week deleted the repo/14_tokenize branch May 16, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceffort-naver yceffort-naver yceffort-naver approved these changes

Assignees

@2-one-week 2-one-week

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2-one-week @yceffort-naver