Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-pdf] 디바이스의 pixel ratio를 조절합니다. #29

Merged
merged 4 commits into from
Apr 29, 2024
Merged

[react-pdf] 디바이스의 pixel ratio를 조절합니다. #29

merged 4 commits into from
Apr 29, 2024

Conversation

2-one-week
Copy link
Member

Related Issue

Describe your changes

  • 현재 브라우저의 pixel ratio를 확인하여 레이어를 렌더링 합니다.
  • requestAnimationFrame을 적용해서 interaction이 블락되는 경우를 제거합니다.
    • @yceffort-naver 님. 이거 react 18 useTransition 쓰면 좋을 것 같은데, 시간되면 react18로 분기 칠까요?
  • layer 3개에 대한 확인이 필요해서 draft로 두겠습니다.

Request

@2-one-week 2-one-week self-assigned this Apr 26, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3aee230

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yceffort-naver
Copy link
Contributor

useTransition 쓰면 좋을 것 같은데, 시간되면 react18로 분기 칠까요?

하악..... 감당할수있을런지..

@2-one-week 2-one-week changed the title [react-pdf] 디바이스의 pixel ration를 조절합니다. [react-pdf] 디바이스의 pixel ratio를 조절합니다. Apr 28, 2024
@2-one-week 2-one-week marked this pull request as ready for review April 29, 2024 10:51
@2-one-week 2-one-week requested a review from a team as a code owner April 29, 2024 10:51
yceffort-naver
yceffort-naver approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useTransition은 차후에 고민하시죠!

@2-one-week
Copy link
Member Author

감삼다~~

@2-one-week 2-one-week merged commit 6162c33 into epic/react_pdf Apr 29, 2024
4 checks passed
@2-one-week 2-one-week deleted the repo/28_canvas branch April 29, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceffort-naver yceffort-naver yceffort-naver approved these changes

Assignees

@2-one-week 2-one-week

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2-one-week @yceffort-naver