Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-pdf] canvas와 svg로 pdf를 rendering 할 수 있는 컴포넌트를 구현합니다. #19

Merged
merged 8 commits into from
Apr 23, 2024
Merged

[react-pdf] canvas와 svg로 pdf를 rendering 할 수 있는 컴포넌트를 구현합니다. #19

merged 8 commits into from
Apr 23, 2024

Conversation

2-one-week
Copy link
Member

Related Issue

Describe your changes

  • canvas와 svg 중 선택하여 pdf를 rendering 하는 컴포넌트를 구현하고 적용합니다.
  • 스토리북을 추가하여 구현합니다.
  • zero-dependency가 목표이기 때문에, useIsomorphicLayoutEffect 와 같은 애들은 내장했습니다.

Request

@2-one-week 2-one-week self-assigned this Apr 23, 2024
@2-one-week 2-one-week requested a review from a team as a code owner April 23, 2024 13:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: acd6630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from repo/17_backborn to epic/react_pdf April 23, 2024 13:55
yceffort-naver
yceffort-naver approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시작이 반이다~~

@2-one-week
Copy link
Member Author

감사합니다~

@2-one-week 2-one-week merged commit 9161afa into epic/react_pdf Apr 23, 2024
3 checks passed
@2-one-week 2-one-week deleted the repo/13_pdf_render branch April 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceffort-naver yceffort-naver yceffort-naver approved these changes

Assignees

@2-one-week 2-one-week

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2-one-week @yceffort-naver