Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirroring and rotating can leave behind artifacts #16

Closed
jrdh opened this issue Jan 19, 2022 · 0 comments · Fixed by #22
Closed

Mirroring and rotating can leave behind artifacts #16

jrdh opened this issue Jan 19, 2022 · 0 comments · Fixed by #22
Assignees
Labels
bug Something isn't working

Comments

@jrdh
Copy link
Member

jrdh commented Jan 19, 2022

For example consider this (https://data.nhm.ac.uk/media/1d278ef1-35e2-41b5-bb34-aeaf35ff02e9/0,0,2048,2048/1500,/0/default.jpg):

default

vs. this (https://data.nhm.ac.uk/media/1d278ef1-35e2-41b5-bb34-aeaf35ff02e9/0,0,2048,2048/319,/!0/default.jpg):

default

See the right hand edge where something isn't right. This is due to a limitation in the jpegtran lib, as noted here: jbaiter/jpegtran-cffi#23.

Most sensible remedy is probably to do something similar to what we're doing with crops that don't divide by 16 - do as much as we can in jpegtran but then passing the image to another lib to do the final bit of work? Might be possible here, might not, will require some investigation. At the very least doing rotations isn't a high throughput op so if it isn't as fast as other ops it's probably not the end of the world.

@jrdh jrdh added the bug Something isn't working label Jan 19, 2022
@jrdh jrdh self-assigned this May 14, 2022
@jrdh jrdh mentioned this issue May 16, 2022
@jrdh jrdh closed this as completed in #22 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant