From 5236551776f0bd41b09c5735e58592bc26e6ce55 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Mon, 24 Jun 2024 20:37:42 +0200 Subject: [PATCH] [skip ci] Remove obsolete guideline how to comment out code (#14621) This can lead to undefined warnings when building with -Wundef and using undefined FOO macro in #if condition. Also such code disabling should not be encouraged exactly. --- CODING_STANDARDS.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/CODING_STANDARDS.md b/CODING_STANDARDS.md index 3924227c914f0..a8bac89cbe566 100644 --- a/CODING_STANDARDS.md +++ b/CODING_STANDARDS.md @@ -55,11 +55,6 @@ rewritten to comply with these rules. the source. Although the `PHP_*` macros are mostly aliased to the `ZEND_*` macros it gives a better understanding on what kind of macro you're calling. -1. When commenting out code using a `#if` statement, do NOT use `0` only. - Instead, use `"_0"`. For example, `#if FOO_0`, - where `FOO` is your git user `foo`. This allows easier tracking of why - code was commented out, especially in bundled libraries. - 1. Do not define functions that are not available. For instance, if a library is missing a function, do not define the PHP version of the function, and do not raise a run-time error about the function not existing. End users should