Skip to content

Commit c1cdf0e

Browse files
edusperoniNathanWalker
authored andcommitted
docs: drop stale smart-stringify references from primordials notes
1 parent 1a57398 commit c1cdf0e

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

NativeScript/runtime/BuiltinLoader.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ MaybeLocal<Value> CallBuiltin(Local<Context> context, BuiltinId id,
124124
}
125125

126126
// Snapshot of the intrinsics, taken the first time any builtin runs in this
127-
// isolate — during runtime init, before user code can replace a global. Later
128-
// builtins (smart-stringify compiles lazily, on the first object logged) get
129-
// the same pristine snapshot.
127+
// isolate — during runtime init, before user code can replace a global.
128+
// Builtins compiled later in the isolate's life get the same pristine
129+
// snapshot.
130130
MaybeLocal<Object> GetPrimordials(Local<Context> context) {
131131
Isolate* isolate = v8::Isolate::GetCurrent();
132132
std::shared_ptr<Caches> cache = Caches::Get(isolate);

NativeScript/runtime/js/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,8 @@ module.exports = somethingTheCallSiteNeeds;
6363
`primordials.js` runs first in every isolate — lazily, on the first
6464
`RunBuiltin` call, which happens during runtime init — and its frozen,
6565
null-prototype export is cached per isolate (`Caches::Primordials`) and
66-
handed to every other builtin. Builtins that compile late (`smart-stringify`
67-
is compiled on the first object logged) therefore still see intrinsics as they
68-
were before user code ran.
66+
handed to every other builtin, so a builtin that compiles later in the
67+
isolate's life still sees intrinsics as they were before user code ran.
6968

7069
Naming follows Node: statics keep their path (`JSONStringify`,
7170
`ObjectDefineProperty`), instance methods are **uncurried** so the receiver

0 commit comments

Comments
 (0)