fix(runtime): shim removeListener drops the newest registration; an adopted port is recorded before the list write can fail

WorkerEmitter.removeListener scanned forwards while ParentPort and Node
remove the most recently added registration. In Deserialize a port adopted
successfully but not yet recorded was skipped by the failure cleanup when
the ports array write failed, leaving it registered with no handle.

Author: edusperoni

NativeScript/runtime/StructuredSerialization.cpp

@@ -685,13 +685,18 @@ MaybeLocal<Value> SerializedValue::Deserialize(Isolate* isolate,
     for (size_t i = 0; i < transferredPorts_.size(); i++) {
       Local<Object> wrapper;
       if (!messaging::AdoptPort(context, std::move(transferredPorts_[i]))
-               .ToLocal(&wrapper) ||
-          !list->Set(context, static_cast<uint32_t>(i), wrapper)
-               .FromMaybe(false)) {
+               .ToLocal(&wrapper)) {
         CloseUnreachablePorts(isolate, ports, nullptr);
         return MaybeLocal<Value>();
       }
+      // Recorded before anything else can fail: an adopted port that is not
+      // in this list would never be closed.
       ports.push_back(wrapper);
+      if (!list->Set(context, static_cast<uint32_t>(i), wrapper)
+               .FromMaybe(false)) {
+        CloseUnreachablePorts(isolate, ports, nullptr);
+        return MaybeLocal<Value>();
+      }
     }
     if (portList != nullptr) {
       *portList = list;

NativeScript/runtime/js/node-worker-threads.js

@@ -104,12 +104,13 @@ class WorkerEmitter {
     return this;
   }
 
+  // Node removes the most recently added registration of a listener.
   removeListener(type, listener) {
     const list = this.#listeners[`${type}`];
     if (list === undefined) {
       return this;
     }
-    for (let i = 0; i < list.length; i++) {
+    for (let i = list.length - 1; i >= 0; i--) {
       if (list[i].listener === listener) {
         ArrayPrototypeSplice(list, i, 1);
         return this;