fix(worker): isolate and wrapper lifetime fixes around startup and teardown #683
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| on: | |
| pull_request: | |
| permissions: | |
| contents: read | |
| env: | |
| NPM_TAG: "pr" | |
| XCODE_VERSION: "^16.0" | |
| jobs: | |
| build: | |
| name: Build | |
| runs-on: macos-15 | |
| steps: | |
| - uses: maxim-lobanov/setup-xcode@ed7a3b1fda3918c0306d1b724322adc0b8cc0a90 # v1.7.0 | |
| with: | |
| xcode-version: ${{env.XCODE_VERSION}} | |
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | |
| with: | |
| fetch-depth: 0 | |
| submodules: true | |
| persist-credentials: false # disable to prevent leaking credentials to build scripts | |
| - name: LLVM cache | |
| uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 | |
| with: | |
| path: ./llvm | |
| key: ${{ hashFiles('download_llvm.sh') }} | |
| - uses: ./.github/actions/setup-build-env | |
| - name: Get Current Version | |
| run: | | |
| echo NPM_VERSION=$(node -e "console.log(require('./package.json').version);") >> $GITHUB_ENV | |
| - name: Bump version for PR release | |
| run: | | |
| NPM_VERSION=$(node ./scripts/get-next-version.js) | |
| echo NPM_VERSION=$NPM_VERSION >> $GITHUB_ENV | |
| npm version $NPM_VERSION --no-git-tag-version | |
| - name: Build | |
| # Default (embedded) SwiftPM mode: the xcframework zips ship inside the | |
| # package, so the artifact below is self-contained — download it and | |
| # use it directly with `ns platform add ios --framework-path=<tgz>`. | |
| run: npm run build-ios | |
| - name: Upload npm package artifact | |
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | |
| with: | |
| name: npm-package | |
| path: dist/nativescript-ios-${{env.NPM_VERSION}}.tgz | |
| - name: Upload SwiftPM artifacts (xcframework zips + checksums) | |
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | |
| with: | |
| name: spm-artifacts | |
| path: dist/artifacts/* | |
| - name: Upload dSYMs artifact | |
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | |
| with: | |
| name: NativeScript-dSYMs | |
| path: dist/dSYMs | |
| test: | |
| name: Test | |
| runs-on: macos-15 | |
| needs: build | |
| steps: | |
| - uses: maxim-lobanov/setup-xcode@ed7a3b1fda3918c0306d1b724322adc0b8cc0a90 # v1.7.0 | |
| with: | |
| xcode-version: ${{env.XCODE_VERSION}} | |
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | |
| with: | |
| submodules: true | |
| persist-credentials: false # disable to prevent leaking credentials to build scripts | |
| - name: LLVM cache | |
| uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 | |
| with: | |
| path: ./llvm | |
| key: ${{ hashFiles('download_llvm.sh') }} | |
| - uses: ./.github/actions/setup-build-env | |
| with: | |
| install-test-tools: "true" | |
| - name: Prepare test folder | |
| id: prepare-test-folder | |
| run: | | |
| mkdir -p dist-test | |
| echo TEST_FOLDER=$(pwd)/dist-test >> $GITHUB_ENV | |
| - name: Xcode Tests | |
| uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0 | |
| # try to run the tests with xcpretty. If it fails then try again without xcpretty twice for better log output | |
| # the xcode tests are a bit flaky and they should never fail on this step, as this step only collects the JS test results as junit xml | |
| with: | |
| # Build (~10m) + the runtime suite's report-wait (up to 10m, see | |
| # TestRunnerTests.swift) need more than 20m headroom per attempt. | |
| timeout_minutes: 40 | |
| max_attempts: 2 | |
| command: set -o pipefail && xcodebuild -project v8ios.xcodeproj -scheme TestRunner -resultBundlePath $TEST_FOLDER/test_results -destination platform\=iOS\ Simulator,OS\=latest,name\=iPhone\ 16\ Pro build test | xcpretty | |
| # Keep the failed attempt's bundle — it holds the diagnostics of the | |
| # failure being retried. Everything else at the result path must go | |
| # (including extensionless staging leftovers), or the retry dies with | |
| # "Existing file at -resultBundlePath". | |
| on_retry_command: rm -rf $TEST_FOLDER/test_results_attempt1.xcresult; mv $TEST_FOLDER/test_results.xcresult $TEST_FOLDER/test_results_attempt1.xcresult 2>/dev/null; for f in $TEST_FOLDER/test_results*; do [ "$f" = "$TEST_FOLDER/test_results_attempt1.xcresult" ] || rm -rf "$f"; done; xcrun simctl shutdown all | |
| new_command_on_retry: xcodebuild -project v8ios.xcodeproj -scheme TestRunner -resultBundlePath $TEST_FOLDER/test_results -destination platform\=iOS\ Simulator,OS\=latest,name\=iPhone\ 16\ Pro build test | |
| - name: Extract test results | |
| # Runs even when the test step failed: the xcresult usually still | |
| # carries the JS suite's junit attachments for the report step below. | |
| if: ${{ !cancelled() }} | |
| run: | | |
| if [ -d "$TEST_FOLDER/test_results.xcresult" ]; then | |
| xcparse attachments $TEST_FOLDER/test_results.xcresult $TEST_FOLDER/test-out | |
| fi | |
| - name: Test report summary | |
| if: ${{ !cancelled() }} | |
| # annotate_only keeps this usable from fork PRs: it reports via workflow | |
| # commands and the step summary, so no checks:write token is needed | |
| uses: mikepenz/action-junit-report@a9170d5795813c01ab4901ffb045b52bab4ab09d # v6.5.0 | |
| with: | |
| report_paths: dist-test/test-out/*junit*.xml | |
| annotate_only: true | |
| detailed_summary: true | |
| - name: Validate Test Results | |
| run: | | |
| find $TEST_FOLDER/test-out -name "*junit*.xml" -maxdepth 1 -print0 | xargs -n 1 -0 npx junit-cli-report-viewer | |
| find $TEST_FOLDER/test-out -name "*junit*.xml" -maxdepth 1 -print0 | xargs -n 1 -0 npx verify-junit-xml | |
| - name: Collect test diagnostics | |
| if: failure() | |
| uses: ./.github/actions/collect-test-diagnostics | |
| with: | |
| test-folder: ${{env.TEST_FOLDER}} | |
| - name: Archive Test Result Data | |
| if: always() | |
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | |
| with: | |
| name: test-results | |
| path: | | |
| ${{env.TEST_FOLDER}}/test_results.xcresult | |
| ${{env.TEST_FOLDER}}/test_results_attempt1.xcresult |