Skip to content

Commit c54376a

Browse files
committed
fix(fireforce): use serializeItems
1 parent bdacb06 commit c54376a

File tree

2 files changed

+21
-37
lines changed

2 files changed

+21
-37
lines changed

packages/firebase-firestore/index.ios.ts

+20-36
Original file line numberDiff line numberDiff line change
@@ -548,106 +548,90 @@ export class Query<T extends DocumentData = DocumentData> implements IQuery<T> {
548548
if (fieldPath instanceof FieldPath) {
549549
switch (opStr) {
550550
case '!=':
551-
query = this.native.queryWhereFieldPathIsNotEqualTo(fieldPath.native, value?.native || value);
551+
query = this.native.queryWhereFieldPathIsNotEqualTo(fieldPath.native, serializeItems(value));
552552
break;
553553
case '<':
554-
query = this.native.queryWhereFieldPathIsLessThan(fieldPath.native, value?.native || value);
554+
query = this.native.queryWhereFieldPathIsLessThan(fieldPath.native, serializeItems(value));
555555
break;
556556
case '>':
557-
query = this.native.queryWhereFieldPathIsGreaterThan(fieldPath.native, value?.native || value);
557+
query = this.native.queryWhereFieldPathIsGreaterThan(fieldPath.native, serializeItems(value));
558558
break;
559559
case '<=':
560-
query = this.native.queryWhereFieldPathIsLessThanOrEqualTo(fieldPath.native, value?.native || value);
560+
query = this.native.queryWhereFieldPathIsLessThanOrEqualTo(fieldPath.native, serializeItems(value));
561561
break;
562562
case '>=':
563-
query = this.native.queryWhereFieldPathIsGreaterThanOrEqualTo(fieldPath.native, value?.native || value);
563+
query = this.native.queryWhereFieldPathIsGreaterThanOrEqualTo(fieldPath.native, serializeItems(value));
564564
break;
565565
case '==':
566-
query = this.native.queryWhereFieldPathIsEqualTo(fieldPath.native, value?.native || value);
566+
query = this.native.queryWhereFieldPathIsEqualTo(fieldPath.native, serializeItems(value));
567567
break;
568568
case 'array-contains':
569569
query = this.native.queryWhereFieldPathArrayContains(
570570
fieldPath.native,
571-
Array.isArray(value) ? value.map((val) => {
572-
return val?.native || val;
573-
}) : value
571+
serializeItems(value)
574572
);
575573
break;
576574
case 'array-contains-any':
577575
query = this.native.queryWhereFieldPathArrayContainsAny(
578576
fieldPath.native,
579-
value.map((val) => {
580-
return val?.native || val;
581-
})
577+
serializeItems(value)
582578
);
583579
break;
584580
case 'in':
585581
query = this.native.queryWhereFieldPathIn(
586582
fieldPath.native,
587-
value.map((val) => {
588-
return val?.native || val;
589-
})
583+
serializeItems(value)
590584
);
591585
break;
592586
case 'not-in':
593587
query = this.native.queryWhereFieldPathNotIn(
594588
fieldPath.native,
595-
value.map((val) => {
596-
return val?.native || val;
597-
})
589+
serializeItems(value)
598590
);
599591
break;
600592
}
601593
} else {
602594
switch (opStr) {
603595
case '!=':
604-
query = this.native.queryWhereFieldIsNotEqualTo(fieldPath as any, value?.native || value);
596+
query = this.native.queryWhereFieldIsNotEqualTo(fieldPath as any, serializeItems(value));
605597
break;
606598
case '<':
607-
query = this.native.queryWhereFieldIsLessThan(fieldPath as any, value?.native || value);
599+
query = this.native.queryWhereFieldIsLessThan(fieldPath as any, serializeItems(value));
608600
break;
609601
case '>':
610-
query = this.native.queryWhereFieldIsGreaterThan(fieldPath as any, value?.native || value);
602+
query = this.native.queryWhereFieldIsGreaterThan(fieldPath as any, serializeItems(value));
611603
break;
612604
case '<=':
613-
query = this.native.queryWhereFieldIsLessThanOrEqualTo(fieldPath as any, value?.native || value);
605+
query = this.native.queryWhereFieldIsLessThanOrEqualTo(fieldPath as any, serializeItems(value));
614606
break;
615607
case '>=':
616-
query = this.native.queryWhereFieldIsGreaterThanOrEqualTo(fieldPath as any, value?.native || value);
608+
query = this.native.queryWhereFieldIsGreaterThanOrEqualTo(fieldPath as any, serializeItems(value));
617609
break;
618610
case '==':
619-
query = this.native.queryWhereFieldIsEqualTo(fieldPath as any, value?.native || value);
611+
query = this.native.queryWhereFieldIsEqualTo(fieldPath as any, serializeItems(value));
620612
break;
621613
case 'array-contains':
622614
query = this.native.queryWhereFieldArrayContains(
623615
fieldPath as any,
624-
value.map((val) => {
625-
return val?.native || val;
626-
})
616+
serializeItems(value)
627617
);
628618
break;
629619
case 'array-contains-any':
630620
query = this.native.queryWhereFieldArrayContainsAny(
631621
fieldPath as any,
632-
Array.isArray(value) ? value.map((val) => {
633-
return val?.native || val;
634-
}) : value
622+
serializeItems(value)
635623
);
636624
break;
637625
case 'in':
638626
query = this.native.queryWhereFieldIn(
639627
fieldPath as any,
640-
value.map((val) => {
641-
return val?.native || val;
642-
})
628+
serializeItems(value)
643629
);
644630
break;
645631
case 'not-in':
646632
query = this.native.queryWhereFieldNotIn(
647633
fieldPath as any,
648-
value.map((val) => {
649-
return val?.native || val;
650-
})
634+
serializeItems(value)
651635
);
652636
break;
653637
}

packages/firebase-firestore/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-firestore",
3-
"version": "1.0.0-alpha.15",
3+
"version": "1.0.0-alpha.16",
44
"description": "NativeScript Firebase - Firestore",
55
"main": "index",
66
"typings": "index.d.ts",

0 commit comments

Comments
 (0)