New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLHttpRequest break NS default functionality #87

Open

CatchABus opened this issue Aug 12, 2022 · 2 comments

Labels

Contributor

CatchABus commented Aug 12, 2022

NativeScript Core already contains a polyfill for XMLHttpRequest here:
https://github.com/NativeScript/NativeScript/blob/main/packages/core/xhr/index.ts

Canvas-polyfill uses its own polyfill: https://github.com/NativeScript/canvas/blob/master/packages/canvas-polyfill/async/xhr/TNSXMLHttpRequest.ts

This breaks functionality for libraries that use default NS polyfill (e.g. axios).

Member

triniwiz commented Aug 12, 2022

There are somethings I need to add back into core to ensure the 3rd party libs used with canvas remain functional , that’s the only reason it exists

triniwiz added the enhancement label

Member

triniwiz commented Aug 22, 2024

Time to to move the extra features into core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment