Skip to content

Commit 33c7337

Browse files
committed
chore: align branch with main tooling after rebase
- bump ts-jest to 29.4.12 so jest specs compile under TypeScript 6 (29.4.9 forced moduleResolution=node10, which TS 6 rejects) - satisfy eslint 9 no-empty / no-empty-function / no-this-alias rules now enforced by main's flat config
1 parent f209a48 commit 33c7337

5 files changed

Lines changed: 37 additions & 11 deletions

File tree

package-lock.json

Lines changed: 18 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
"sass": "1.72.0",
109109
"sinon": "^17.0.0",
110110
"tailwindcss": "~3.4.0",
111-
"ts-jest": "29.4.9",
111+
"ts-jest": "29.4.12",
112112
"ts-node": "10.9.2",
113113
"tslib": "^2.8.0",
114114
"typescript": "6.0.3",

packages/angular/src/lib/application.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) {
369369
NativeScriptDebug.hmrLog(`cleared Angular route caches before reboot: detachedViews=${clearedDetached} routeFields=${cleared} locationState=${JSON.stringify(clearedLocation)}`);
370370
}
371371
}
372-
} catch {}
372+
} catch {
373+
// ignore
374+
}
373375
};
374376
const updatePlatformRef = (moduleRef: NgModuleRef<T | K> | ApplicationRef, reason: NgModuleReason) => {
375377
const newPlatformRef = moduleRef.injector.get(PlatformRef);
@@ -392,7 +394,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) {
392394

393395
try {
394396
(currentRoot as any)._onCssStateChange?.();
395-
} catch {}
397+
} catch {
398+
// ignore
399+
}
396400
}, 0);
397401
};
398402
const setRootView = (ref: NgModuleRef<T | K> | ApplicationRef | View) => {
@@ -815,7 +819,9 @@ export function runNativeScriptAngularApp<T, K>(options: AppRunOptions<T, K>) {
815819
}
816820
try {
817821
global['__NS_CAPTURE_ANGULAR_HMR_ROUTE__']?.();
818-
} catch {}
822+
} catch {
823+
// ignore
824+
}
819825
disposeLastModules('hotreload');
820826
if (traceEnabled) {
821827
NativeScriptDebug.hmrLog(`after disposeLastModules cycle=${cycleNum} bootstrapId=${bootstrapId}`);

packages/angular/src/lib/hmr-cache-store.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ export class HmrCacheStore {
185185
typeof requested === 'number' && requested > 0
186186
? Math.floor(requested)
187187
: 0;
188+
// eslint-disable-next-line @typescript-eslint/no-empty-function
188189
this._log = options.log ?? (() => {});
189190
// Trim seed if it overshoots the configured ceiling — possible if
190191
// a previous session ran with a larger `maxEntries` than this one.
@@ -267,6 +268,7 @@ export class HmrCacheStore {
267268
throw new Error('[HmrCacheStore] scope() requires a non-empty prefix');
268269
}
269270
const fullPrefix = `${prefix}:`;
271+
// eslint-disable-next-line @typescript-eslint/no-this-alias
270272
const parent = this;
271273
return {
272274
prefix: fullPrefix,
@@ -356,6 +358,7 @@ export function createDefaultHmrCacheStore(
356358
const invalidateEventName =
357359
options.invalidateEventName ?? DEFAULT_INVALIDATE_EVENT;
358360
const maxEntries = options.maxEntries ?? DEFAULT_MAX_ENTRIES;
361+
// eslint-disable-next-line @typescript-eslint/no-empty-function
359362
const log = options.log ?? (() => {});
360363

361364
const hot = readImportMetaHot();

packages/angular/src/lib/legacy/router/hmr-route-cache-core.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ function destroyRouteCacheValue(value: unknown): void {
1818
if (typeof destroy === 'function') {
1919
try {
2020
destroy.call(value);
21-
} catch {}
21+
} catch {
22+
// ignore
23+
}
2224
}
2325
}
2426

@@ -36,7 +38,9 @@ function clearRouteCacheField(route: Record<string, unknown>, key: (typeof ROUTE
3638
} catch {
3739
try {
3840
route[key] = undefined;
39-
} catch {}
41+
} catch {
42+
// ignore
43+
}
4044
}
4145

4246
return true;

0 commit comments

Comments
 (0)