Skip to content

Commit e0e92bf

Browse files
committed
chore: update readme
1 parent 2a694fb commit e0e92bf

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

test-app/runtime/src/main/java/com/tns/Runtime.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,9 @@ public Runtime(StaticConfiguration config, DynamicConfiguration dynamicConfigura
220220
if (config.appConfig.getEnableMultithreadedJavascript()) {
221221
this.strongInstances = new ConcurrentHashMap<>();
222222
this.weakInstances = new ConcurrentHashMap<>();
223-
// TODO: figure out why using a concurrent map for loadedJavaScriptExtends
224-
// results in a fail of TestCanFindImplementationObjectWhenCreateExtendedObjectFromJava
225-
// with java.lang.reflect.InvocationTargetException
226-
// but works with synchronizeMap
227-
this.loadedJavaScriptExtends = Collections.synchronizedMap(new HashMap<>());
223+
// TODO: can't use a ConcurrentHashMap for loadedJavaScriptExtends because it loads null objects, which aren't supported
224+
// either leave it like this or create a separate set for null caches
225+
this.loadedJavaScriptExtends = new ConcurrentHashMap<>();
228226
this.strongJavaObjectToID = Collections.synchronizedMap(new NativeScriptHashMap<>());
229227
this.weakJavaObjectToID = Collections.synchronizedMap(new NativeScriptWeakHashMap<>());
230228
}

0 commit comments

Comments
 (0)