feat: expose timers under the standard global names

Register setTimeout/setInterval/clearTimeout/clearInterval directly on
every global (workers included), keeping the __ns__-prefixed variants
for backwards compatibility. The test app's Handler-based setTimeout
polyfill is retired: the suite now runs on the native timers.

Author: edusperoni

test-app/app/src/main/assets/app/Infrastructure/timers.js

@@ -1,51 +1,3 @@
-var timeoutHandler;
-var timeoutCallbacks = {};
-function createHadlerAndGetId() {
-    if (!timeoutHandler) {
-        timeoutHandler = new android.os.Handler(android.os.Looper.getMainLooper());
-    }
-    return new Date().getUTCMilliseconds();
-}
-function setTimeout(callback, milliseconds) {
-    if (milliseconds === void 0) { milliseconds = 0; }
-    var id = createHadlerAndGetId();
-    var runnable = new java.lang.Runnable({
-        run: function () {
-            callback();
-            if (timeoutCallbacks && timeoutCallbacks[id]) {
-                timeoutCallbacks[id] = null;
-            }
-        }
-    });
-    if (!timeoutCallbacks[id]) {
-        timeoutCallbacks[id] = runnable;
-    }
-    timeoutHandler.postDelayed(runnable, long(milliseconds));
-    return id;
-}
-global.setTimeout = setTimeout;
-function clearTimeout(id) {
-    if (timeoutCallbacks[id]) {
-        timeoutHandler.removeCallbacks(timeoutCallbacks[id]);
-        timeoutCallbacks[id] = null;
-    }
-}
-global.clearTimeout = clearTimeout;
-function setInterval(callback, milliseconds) {
-    if (milliseconds === void 0) { milliseconds = 0; }
-    var id = createHadlerAndGetId();
-    var handler = timeoutHandler;
-    var runnable = new java.lang.Runnable({
-        run: function () {
-            callback();
-            handler.postDelayed(runnable, long(milliseconds));
-        }
-    });
-    if (!timeoutCallbacks[id]) {
-        timeoutCallbacks[id] = runnable;
-    }
-    timeoutHandler.postDelayed(runnable, long(milliseconds));
-    return id;
-}
-global.setInterval = setInterval;
-global.clearInterval = clearTimeout;
+// Kept only because scripts in the shared tests submodule still require this
+// path; setTimeout/setInterval/clearTimeout/clearInterval are provided
+// natively by the runtime on every global (including workers).

test-app/app/src/main/assets/app/boot.js

@@ -13,7 +13,6 @@ global.__onUncaughtError = function(error){
 	return true;
 }
 
-require('./Infrastructure/timers');
 global.__JUnitSaveResults = function (unitTestResults) {
 	var pathToApp = '/data/data/com.tns.testapplication';
 	var unitTestFileName = 'android_unit_test_results.xml';

test-app/app/src/main/assets/app/tests/testEventLoop.js

@@ -91,8 +91,6 @@ describe("event loop ordered macrotasks", function () {
         Promise.resolve().then(() => order.push("microtask"));
     });
 
-    // native timers (__ns__*): the app-level `setTimeout` global in this test
-    // app is an old Handler-based polyfill, not the runtime timers
     it("stays FIFO-ordered with native setTimeout(0)", function (done) {
         const order = [];
         __ns__queueMacrotask(() => order.push("macro1"));

test-app/app/src/main/assets/app/tests/testNativeTimers.js

@@ -16,6 +16,33 @@ describe('native timer', () => {
         expect(clearInterval).toBeDefined();
     });
 
+    it('is exposed under the standard global names', () => {
+        expect(typeof global.setTimeout).toBe('function');
+        expect(typeof global.setInterval).toBe('function');
+        expect(typeof global.clearTimeout).toBe('function');
+        expect(typeof global.clearInterval).toBe('function');
+    });
+
+    it('triggers and cancels via the standard global names', (done) => {
+        let cancelledFired = false;
+        const cancelled = global.setTimeout(() => {
+            cancelledFired = true;
+        }, 50);
+        global.clearTimeout(cancelled);
+        let intervalCalls = 0;
+        const itv = global.setInterval(() => {
+            intervalCalls++;
+            if (intervalCalls >= 2) {
+                global.clearInterval(itv);
+            }
+        }, 20);
+        global.setTimeout(() => {
+            expect(cancelledFired).toBe(false);
+            expect(intervalCalls).toBe(2);
+            done();
+        }, 200);
+    });
+
     it('triggers timeout', (done) => {
         const now = Date.now();
         setTimeout(() => {

test-app/runtime/src/main/cpp/Timers.cpp

@@ -60,11 +60,17 @@ namespace tns {
 
 void Timers::Init(v8::Isolate *isolate, v8::Local<v8::ObjectTemplate> &globalObjectTemplate) {
     isolate_ = isolate;
-    // TODO: remove the __ns__ prefix once this is validated
-    SetMethod(isolate, globalObjectTemplate, "__ns__setTimeout", SetTimeoutCallback, External::New(isolate, this, v8::kExternalPointerTypeTagDefault));
-    SetMethod(isolate, globalObjectTemplate, "__ns__setInterval", SetIntervalCallback, External::New(isolate, this, v8::kExternalPointerTypeTagDefault));
-    SetMethod(isolate, globalObjectTemplate, "__ns__clearTimeout", ClearTimer, External::New(isolate, this, v8::kExternalPointerTypeTagDefault));
-    SetMethod(isolate, globalObjectTemplate, "__ns__clearInterval", ClearTimer, External::New(isolate, this, v8::kExternalPointerTypeTagDefault));
+    Local<External> data = External::New(isolate, this, v8::kExternalPointerTypeTagDefault);
+    // the __ns__-prefixed variants are kept for backwards compatibility with
+    // callers that predate the timers being exposed under their standard names
+    SetMethod(isolate, globalObjectTemplate, "setTimeout", SetTimeoutCallback, data);
+    SetMethod(isolate, globalObjectTemplate, "setInterval", SetIntervalCallback, data);
+    SetMethod(isolate, globalObjectTemplate, "clearTimeout", ClearTimer, data);
+    SetMethod(isolate, globalObjectTemplate, "clearInterval", ClearTimer, data);
+    SetMethod(isolate, globalObjectTemplate, "__ns__setTimeout", SetTimeoutCallback, data);
+    SetMethod(isolate, globalObjectTemplate, "__ns__setInterval", SetIntervalCallback, data);
+    SetMethod(isolate, globalObjectTemplate, "__ns__clearTimeout", ClearTimer, data);
+    SetMethod(isolate, globalObjectTemplate, "__ns__clearInterval", ClearTimer, data);
 
     // PrepareV8Runtime bound the loop to this thread's looper before any
     // builtin initialization runs