fix(runtime): let termination outrank settlement in PumpUntil

A Terminate() racing an entry that genuinely settles returned kSettled,
and the caller went on to run JS (worker queue enable, drains) on an
isolate with TerminateExecution pending. Both settle probes now funnel
through the loop head, where the termination check comes first; a
fulfilled module's registration is untouched on that path, only its
result is discarded.

Author: edusperoni

test-app/runtime/src/main/cpp/EventLoop.cpp

@@ -736,16 +736,18 @@ EventLoop::PumpResult EventLoop::PumpUntil(double deadlineSeconds,
     const auto deadline = std::chrono::steady_clock::now() +
                           std::chrono::duration<double>(deadlineSeconds);
     for (;;) {
-        if (settled()) {
-            return PumpResult::kSettled;
-        }
         // Both probes: IsExecutionTerminating is true only while JS frames
         // unwind with the termination exception active, so a pump parked with
         // nothing queued would never observe TerminateExecution through it.
+        // Termination outranks settlement: consuming a settled result means
+        // running more JS, which a terminating isolate must not do.
         if (terminationRequested_.load(std::memory_order_acquire) ||
             isolate_->IsExecutionTerminating()) {
             return PumpResult::kTerminated;
         }
+        if (settled()) {
+            return PumpResult::kSettled;
+        }
         if (IsStopped()) {
             // a stopped loop drops every post, so nothing can settle anymore
             return PumpResult::kTerminated;
@@ -771,7 +773,9 @@ EventLoop::PumpResult EventLoop::PumpUntil(double deadlineSeconds,
             }
         }
         if (settled()) {
-            return PumpResult::kSettled;
+            // back through the loop head, where termination outranks the
+            // settlement this drain produced
+            continue;
         }
         if (ranLooperWork == 0) {
             WaitForInternalWork(10, /*pumpDeliverable=*/drainLooperWork);