Hardcoded language terms

[DominikSLK]

Describe the issue

Nameless/modules/Core/classes/Group_Sync/NamelessMCGroupSyncInjector.php

Line 17 in 0396359

return 'Website group';

Nameless/modules/Core/classes/Group_Sync/MinecraftGroupSyncInjector.php

Line 17 in 0396359

return 'Minecraft rank';

Nameless/modules/Discord Integration/classes/DiscordGroupSyncInjector.php

Line 17 in 0396359

return 'Discord role';

NamelessMC Version

2.1.0

To Reproduce

No response

Expected Behaviour

No response

Screenshots

No response

Additional Information

No response

[Derkades]

Is this shown anywhere in StaffCP?

[DominikSLK]

yes it is on the page where you select groups for group sync

[samerton]

Not sure how to fix this with how it works at the moment.

Let's say we pass a Language instance into the getName method to allow for translations. Currently we have no context as to which Language instance to use - imagine there is a custom module which adds injectors (even in the case of Discord Integration) - the code would not know which Language instance to pass in.