Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message when no members defined in host/service groups #925

Open
tsadpbb opened this issue Aug 15, 2023 · 0 comments
Open
Labels

Comments

@tsadpbb
Copy link
Contributor

tsadpbb commented Aug 15, 2023

What

If you define all of your host and service groups such that they do not have members, like so

define servicegroup {
	servicegroup_name	testservicegroup 
	alias	Sample Service Group  
	}

Then you get an authentication message:
"It appears as though you do not have permission to view information for any of the hosts you requested..."

Why

In cgiauth.c around lines 300 and 329, if the temp_servicesmember and temp_hostsmember is already NULL, authorization returns false.

Suggestions to fix

  • A different error message can be shown instead of one that suggests the user doesn't have permissions.
  • On startup, a host group and service group could require members. Could break some things.
  • Make a conditional before the for loop that return TRUE if the members are null. Could break some things.
@sawolf sawolf added the Bug label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants