Fix for rendering of weathermap halves #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `conf.line_cut` values of 0 and 1 only one half of line should be drawn. Unfortunately, disabling one of the two `renderArrow`s messes up `parts` array id's and consequently label drawing. This patch is intended to fix render behavior for these values while disabling labels functionality for affected weathermap lines. Haven't found easy way to make labels work as well, as it would seemingly require big changes to how render code for weathermap lines works.
Contributor
|
Seems that cases 1/0 were not really treated meaningfully. However, the label treatment is not good. Couldn't we evaluate in line_cut in renderLables again and then paint only the label of the part that is visible? |
Author
|
I tried that, but it breaks labeled line with value 1 completely because parts[id] values corresponding to it are null. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
conf.line_cutvalues of 0 and 1 only one half of line should be drawn.Unfortunately, disabling one of the two
renderArrows messes uppartsarray id's and consequently label drawing.This patch is intended to fix render behavior for these values while disabling labels functionality for affected weathermap lines.
Haven't found easy way to make labels work as well, as it would seemingly require big changes to how render code for weathermap lines works.