Incorrect text insertions

[g-plane]

Validations

• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Describe the bug

For the text below:

console.log("Hello, World!")

If we select the not completion item, it will become:

console.log("Hello, !World!")

Besides, if we select the par completion item, it will become:

console.log("Hello, (World!"))

Contributes

• I am willing to submit a PR to fix this issue
• I am willing to submit a PR with failing tests

[NWYLZW]

The current logic for evaluating expressions does not strictly follow semantic expressions, so it cannot accurately determine certain special cases like strings.

shikitor/packages/core/src/plugins/expression-quick-completions.ts

Lines 14 to 21 in a1cbcd5

	let expressionStart = position.offset - 1
	// find the start of the line view width start
	while (expressionStart > 0 && ![
	' ',
	'\t',
	'\r',
	'\n'
	].includes(value[expressionStart - 1])) expressionStart--

Due to the nature of expressions, they tend to be more language-agnostic. Although it may be more appropriate to have corresponding language-specific start and end markers for expressions, it would significantly increase the maintenance and development costs for me. I plan to address this issue by following these steps:

• single and dubdle quote: '', ""
• backtick: `
• brackets: [], (), <>, {}
• single comment: //
• multiple comment: /**/

If anyone can provide assistance with this feature, I would greatly appreciate it.

[g-plane]

You can consider tree-sitter.