Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Is the workflow wrong for XPBD #396

Open
lisiyao21 opened this issue Dec 13, 2024 · 0 comments
Open

[BUG] Is the workflow wrong for XPBD #396

lisiyao21 opened this issue Dec 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lisiyao21
Copy link

Bug Description

Dear contributors, thank you so much for this valuable framework!

Usually, we do wp.collide() before integrator.simulate(). But, when it involves XPBD, it will first integrate the body first and then do constraint solution, where the collision points are those detected before integration in XPBD. Isn't it wrong? Shouldn't the flow be: integrate --> collision --> optimization?

System Information

No response

@lisiyao21 lisiyao21 added the bug Something isn't working label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant