You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Same radius and height give one unique object, whereas up_axis should get another one (or at least change the rotation).
If only the color or the up_axis change, this line will reuse (and update) the same existing cylinder.
This is also the case for Sphere, Arrow, Plane, Capsule, etc. with the at least the color parameter.
Maybe I would suggest to add the name of the object in the hashing ?
If the user want to update an object, he calls again render_cylinder with different parameters and keep the same name,
if he wants a Nth object he changes the name.
Or adding the color and the up_axis in the hashing.
This has also to be update for Arrow, Capsule, etc.
Thank you,
PS: If you are ok with adding the name in the hashing, I can also do a pull request ...
System Information
No response
The text was updated successfully, but these errors were encountered:
Bug Description
Hi,
Thanks for the job around Warp !
I like the OpenGLRenderer for interactive visualization.
If I try to render 2 cylinders with different
color
orup_axis
like this(but with the same radius and half_height):
It renders only one cylinder.
If I want the second cylinder, I have to change a bit his
half_height
like thisThis is because of the code in
warp/render/render_opengl.py
line 2821, functiondef render_cylinder(...
Same radius and height give one unique object, whereas
up_axis
should get another one (or at least change the rotation).If only the
color
or theup_axis
change, this line will reuse (and update) the same existing cylinder.This is also the case for Sphere, Arrow, Plane, Capsule, etc. with the at least the
color
parameter.Maybe I would suggest to add the
name
of the object in the hashing ?If the user want to update an object, he calls again
render_cylinder
with different parameters and keep the same name,if he wants a Nth object he changes the name.
Or adding the
color
and theup_axis
in the hashing.This has also to be update for Arrow, Capsule, etc.
Thank you,
PS: If you are ok with adding the
name
in the hashing, I can also do a pull request ...System Information
No response
The text was updated successfully, but these errors were encountered: