Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification tool: Improve calculation of num of transitions for CPU fallbacks #619

Open
nartal1 opened this issue Oct 16, 2023 · 0 comments
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Oct 16, 2023

Describe the bug
This issue to track the task of improving number of transtions calculations when the tool detects CPU fallbacks for oprators not running on GPU.
Current implementation does a good job of calculating the number of transitions by flattening all the Execs per stage but there could be some scenarios where we might miss calculating the transitions correctly.
For example: Consider an Exec SMJ where SMJ Exec is fed from 2 Sort Execs. If an Exec similar to Sort is not supported on GPU, then the current implementation will calculate the number of transitions as 1 instead of 2. This could be improved.

PS: Current testing on subset of NDS queries and customer queries produced correct number of transitions.

@nartal1 nartal1 added bug Something isn't working ? - Needs Triage core_tools Scope the core module (scala) and removed bug Something isn't working labels Oct 16, 2023
@mattahrens mattahrens added feature request New feature or request and removed ? - Needs Triage labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants