Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support extra arguments in new user tools CLI #574

Closed
mattahrens opened this issue Sep 19, 2023 · 0 comments · Fixed by #646
Closed

[FEA] Support extra arguments in new user tools CLI #574

mattahrens opened this issue Sep 19, 2023 · 0 comments · Fixed by #646
Assignees
@parthosa
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@mattahrens
Copy link
Collaborator

mattahrens commented Sep 19, 2023 •
edited
Loading

Existing user tools allows you to specify additional arguments such as --csv for the profiler command:

spark_rapids_user_tools onprem profiling --csv --eventlogs my-logs

The new CLI does not support it:

ERROR: Could not consume arg: --csv
Usage: ascli profiling --csv --eventlogs my-logs

This also applies to the qualification command for extra arguments such as tools_jar.
@mattahrens mattahrens changed the title [FEA] Support extra arguments in new user toolsCLI for profiler [FEA] Support extra arguments in new user tools CLI for profiler Sep 19, 2023
@mattahrens mattahrens added user_tools Scope the wrapper module running CSP, QualX, and reports (python) and removed ? - Needs Triage labels Sep 19, 2023
@mattahrens mattahrens changed the title [FEA] Support extra arguments in new user tools CLI for profiler [FEA] Support extra arguments in new user tools CLI Sep 21, 2023
@parthosa parthosa mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support extra arguments in new user tools CLI parthosa/spark-rapids-tools
2 participants
@mattahrens @parthosa